Code review comment for lp:~brendan-donegan/checkbox/bug1030871_component_status_table

Revision history for this message
Daniel Manrique (roadmr) wrote :

OK here's the third opinion:

1) I vote for leaving the headers, it's perfectly clear to us but it will confuse newcomers if we remove them. I'd remove the separator though; the column headers belong with the table and the separator, well, separates them creating a somewhat jarring visual break that feels out of place.

2) Graying out only the checkboxes would be better but if it's technically not so easy, I think what we have is good enough.

3) Graying out the buttons should not be *that* hard to do, but I agree that it would be best handled as a separate improvement.

« Back to merge proposal