Code review comment for lp:~brendan-donegan/checkbox-certification/bug1274094

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Hmm.

I'm sure I did follow the directions step by step but I might have made a
mistake. I think we should stop doing it manually, just really script
everything and fix it until we just blindly run the script.

Thanks
ZK

On Sat, Feb 1, 2014 at 3:36 PM, Brendan Donegan <
<email address hidden>> wrote:

> I think you forgot the 'dch -r' step when cutting the release. If you run
> 'dch -i -U' when the current revision is UNRELEASED it just increments the
> version number instead of adding a new revision. I think I'll probably
> rework the documentation to ask to use the script in hwcert-tools - it's
> mature enough now and ensures steps won't be missed.
>
> > No idea. I'll check this at home
> > 1 lut 2014 10:14 "Brendan Donegan" <email address hidden>
> > napisał(a):
> >
> > > Review: Needs Information
> > >
> > > I was fixing the changelog, but might need to do a bit more - @zyga, do
> > > you know why version 0.18 is missing in trunk and the build-depends fix
> > > that was in that revision was moved to 0.19?
> > > --
> > >
> > > https://code.launchpad.net/~brendan-donegan/checkbox-
> > certification/bug1274094/+merge/204360
> > > You are reviewing the proposed merge of
> > > lp:~brendan-donegan/checkbox-certification/bug1274094 into
> > > lp:checkbox-certification.
> > >
> --
>
> https://code.launchpad.net/~brendan-donegan/checkbox-certification/bug1274094/+merge/204360
> You are reviewing the proposed merge of
> lp:~brendan-donegan/checkbox-certification/bug1274094 into
> lp:checkbox-certification.
>

« Back to merge proposal