OIF-qml

Merge lp:~bregma/oif-qml/fix-filter-crash into lp:oif-qml

  1. fix-filter-crash
  2. Merge into trunk
Proposed by Stephen M. Webb
Status: Merged
Merged at revision: 111
Proposed branch: lp:~bregma/oif-qml/fix-filter-crash
Merge into: lp:oif-qml
Diff against target: 13 lines (+2/-1)
1 file modified
src/gesturearea.cpp (+2/-1)
To merge this branch: bzr merge lp:~bregma/oif-qml/fix-filter-crash
Reviewer Review Type Date Requested Status
Chase Douglas (community) Approve
Review via email: mp+79636@code.launchpad.net

Description of the change

Added a required but missing NULL to a geis_filter_add_term() call to prevent segfaults during startup.

To post a comment you must log in.
Revision history for this message
Chase Douglas (chasedouglas) wrote :

Obvious mistake... Thanks for fixing it!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/gesturearea.cpp'
--- src/gesturearea.cpp 2011-08-10 23:50:27 +0000
+++ src/gesturearea.cpp 2011-10-17 23:58:24 +0000
@@ -184,7 +184,8 @@
184 GEIS_FILTER_CLASS,184 GEIS_FILTER_CLASS,
185 GEIS_GESTURE_ATTRIBUTE_TOUCHES,185 GEIS_GESTURE_ATTRIBUTE_TOUCHES,
186 GEIS_FILTER_OP_EQ,186 GEIS_FILTER_OP_EQ,
187 gesture->touches()->start());187 gesture->touches()->start(),
188 NULL);
188189
189 flags =190 flags =
190 subscription_._UNITY_globalGesture() ? (GeisSubscriptionFlags)(191 subscription_._UNITY_globalGesture() ? (GeisSubscriptionFlags)(

Subscribers

People subscribed via source and target branches