120 -static const gchar *geis_gesture_types[] = {
Moved?
252 + g_ptr_array_add(manager->priv->devices, input_device); 496 + g_ptr_array_foreach (priv->devices, (GFunc) g_object_unref, NULL);
Does manager->priv->devices get clean up? Or who owns input_device?
230 + goto final_exit;
333 +final_exit: 334 + return; 335 +}
Cant you just do a 'return;'? Instead of a goto?
362 + for (l = priv->classes; l != NULL; l = l->next) 363 + {
355 + switch (geis_event_type(geis_event)) 356 + {
Most likely just the coding style, but how come its switched from new line style to GNU style? (or the new line + spaces style).
Hopefully these stay constant during the loop:
1172 + for (i = 0; i < geis_groupset_group_count (groupset); ++i) 1182 + for (j = 0; j < geis_group_frame_count (group); ++j)
I couldn't find them defined, or how you add to it soo I wasn't sure if: 1184 + GeisFrame frame = geis_group_frame(group, j);
Would extract, and remove anything from the group_frame. Hopefully not!
« Back to merge proposal
120 -static const gchar *geis_gesture_ types[] = {
Moved?
252 + g_ptr_array_ add(manager- >priv-> devices, input_device);
496 + g_ptr_array_foreach (priv->devices, (GFunc) g_object_unref, NULL);
Does manager- >priv-> devices get clean up? Or who owns input_device?
230 + goto final_exit;
333 +final_exit:
334 + return;
335 +}
Cant you just do a 'return;'? Instead of a goto?
362 + for (l = priv->classes; l != NULL; l = l->next)
363 + {
355 + switch (geis_event_ type(geis_ event))
356 + {
Most likely just the coding style, but how come its switched from new line style to GNU style? (or the new line + spaces style).
Hopefully these stay constant during the loop:
1172 + for (i = 0; i < geis_groupset_ group_count (groupset); ++i) frame_count (group); ++j)
1182 + for (j = 0; j < geis_group_
I couldn't find them defined, or how you add to it soo I wasn't sure if: frame(group, j);
1184 + GeisFrame frame = geis_group_
Would extract, and remove anything from the group_frame. Hopefully not!