Code review comment for lp:~bregma/ginn/build-with-werror
Revision history for this message
| Stephen M. Webb (bregma) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> I confirm that the code needs to be refactored.
> But Stephen, which things you think they need to be rewritten ?
I think the att and wish structures should be modularized further, the functions for handling them are too distributed across source files.
Some changes are necessary to support device-specific wishes.
I would like to see it rewritten using the GEISv2 API (for efficiency reasons).
Note that, other than the GEISv2 rewrite, most of the changes i would like to see are organizational rather than fundamental. By and large, the program does what it should do in a sensible way, but the way it expressed could be improved.
Any rewrite is not as important as extending an effort to provide more wishes. I think the wish mechanism is solid and does not need a change.