Code review comment for lp:~bregma/geis/lp-617301

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Looks fine, builds, installs and works. Some minor things:

Some Python files are still GPL 2+ (e.g. tools/geisview/defaults.py.in).

The documentation for Group says this:

class Group(object):
 """Represents a particular group."""

Since group is a very common word, maybe some clarification would be in order. What is this a group of, exactly?

review: Needs Fixing

« Back to merge proposal