Merge lp:~bregma/geis/lp-1077376 into lp:geis
Proposed by
Stephen M. Webb
Status: | Merged |
---|---|
Approved by: | Daniel d'Andrada |
Approved revision: | 288 |
Merged at revision: | 289 |
Proposed branch: | lp:~bregma/geis/lp-1077376 |
Merge into: | lp:geis |
Diff against target: |
110 lines (+40/-21) 2 files modified
libgeis/geis_subscription.c (+1/-0) libgeis/geis_v1.c (+39/-21) |
To merge this branch: | bzr merge lp:~bregma/geis/lp-1077376 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel d'Andrada (community) | Approve | ||
Review via email: mp+134027@code.launchpad.net |
Commit message
Avoid dereferencing a freed pointer when more than one V1 gesture class is subscribed (lp: #1077376).
Description of the change
Avoids dereferencing a freed pointer when more than one V1 gesture class is subscribed (lp: #1077376).
No new tests are required: current existing tests were failing and now pass with this fix.
Evince no longer crashes with this fix applied.
To post a comment you must log in.
Looks ok, although I would be happier to have a regular test to cover this instead of a xorg-gtest one (which is slow and unreliable). I have to confess xorg-gtest-based tests stopped working for me long ago so I didn't bother running them anymore. I just write and check the regular ones.