Code review comment for lp:~bregma/frame/lp-966290

Revision history for this message
Chase Douglas (chasedouglas) wrote :

Without autoreconf's --force option, which is not used in autogen.sh, aclocal --install will only overwrite a file present in m4/ if the system installed script has a serial version that is newer. It will not overwrite scripts that do not have a serial number. See http://www.gnu.org/savannah-checkouts/gnu/automake/manual/html_node/Serials.html#Serials.

The xorg-macros.m4 file doesn't have serial numbers, so if we committed it we would need to either use autoreconf --force in autogen.sh, or we would need to be diligent about updating it. I don't think we will ever be building in an environment without xorg-macros due to upstream convention and the scripts being available in Ubuntu main, so I would lean towards not committing it.

review: Needs Fixing

« Back to merge proposal