Code review comment for ~bregeer-ctl/cloud-init:bugfix/centos7_resolv

Revision history for this message
Lars Kellogg-Stedman (larsks) wrote :

This all looks fine as far as fixing the immediate problem.

I can't help but feel that there must be a better way to cooperate with networkmanager, because there are some situations in which it's really useful to have nm managing dns (vpn environments in which you want certain domains to resolve via one set of nameservers and everything else via another comes to mind), but this patch is certainly an improvement over the existing situation.

« Back to merge proposal