Code review comment for ~bregeer-ctl/cloud-init:bugfix/centos7_resolv

Revision history for this message
Scott Moser (smoser) wrote :

This generally looks good.
cloud-init gets network configuration from a variety of sources (openstack config drive in 'interfaces(5)' format, config drive in network_data.json format, Nocloud in 'network_config' format....

Some of those have per-interface dns configuration, some do not. It'd be nice to render this per-interface information when we can.

And even in the openstack interfaces 5 format it *could* declare per-network-device dns entries (the parser supports maintaining that information).

The second thing, you need to sign the canonical contributors agreement (http://www.ubuntu.com/legal/contributors). Please do so, and mention to me that you have in irc or here. Let me know if you have any questions on that.

« Back to merge proposal