Code review comment for lp:~bratsche/indicator-session/users-service

Revision history for this message
Ted Gould (ted) wrote :

On Thu, 2009-09-24 at 04:37 +0000, Cody Russell wrote:
> > * I was looking at "CanActivateSessions" call to ConsoleKit. Do
> > you think we should check this earlier and make the menu items
> > sensitive or insensitive based on this?
>
> Should the menuitems even be there if you can never click them? I
> went ahead and made an API on UsersServiceDbus that can check if
> the seat can activate sessions, and we can either make the menuitems
> insensitive or not add them or whatever. For now I didn't change the
> menu, just added the API.

My thought is let's just hide them. The reason being that then sys
admins can use this as a lockdown mode. We have a bug on this from OEM
as well. But we need to hide all the switching items.

CC'ing MPT as well to get his comments.

« Back to merge proposal