Merge lp:~bratsche/ido/focus-changes into lp:ido/0.3

Proposed by Cody Russell
Status: Merged
Merge reported by: David Barth
Merged at revision: not available
Proposed branch: lp:~bratsche/ido/focus-changes
Merge into: lp:ido/0.3
Diff against target: 57 lines (+11/-7) (has conflicts)
2 files modified
configure.ac (+5/-0)
src/idoentrymenuitem.c (+6/-7)
Text conflict in configure.ac
To merge this branch: bzr merge lp:~bratsche/ido/focus-changes
Reviewer Review Type Date Requested Status
Conor Curran (community) Approve
Review via email: mp+35603@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Conor Curran (cjcurran) :
review: Approve
Revision history for this message
David Barth (dbarth) wrote :

That solves the focus issue on the entry

lp:~bratsche/ido/focus-changes updated
66. By Cody Russell

Remove notify.

Revision history for this message
David Barth (dbarth) wrote :

The code was merged in ido/meerkat

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2010-09-14 00:31:26 +0000
+++ configure.ac 2010-09-16 15:01:07 +0000
@@ -2,8 +2,13 @@
2# shamelessly stolen from clutter-gtk2# shamelessly stolen from clutter-gtk
3#3#
4m4_define([ido_major_version], [0])4m4_define([ido_major_version], [0])
5<<<<<<< TREE
5m4_define([ido_minor_version], [2])6m4_define([ido_minor_version], [2])
6m4_define([ido_micro_version], [0])7m4_define([ido_micro_version], [0])
8=======
9m4_define([ido_minor_version], [1])
10m4_define([ido_micro_version], [13])
11>>>>>>> MERGE-SOURCE
712
8m4_define([ido_api_version],13m4_define([ido_api_version],
9 [ido_major_version.ido_minor_version])14 [ido_major_version.ido_minor_version])
1015
=== modified file 'src/idoentrymenuitem.c'
--- src/idoentrymenuitem.c 2010-09-10 21:26:16 +0000
+++ src/idoentrymenuitem.c 2010-09-16 15:01:07 +0000
@@ -161,6 +161,10 @@
161{161{
162 GdkEvent *event = gdk_event_new (GDK_FOCUS_CHANGE);162 GdkEvent *event = gdk_event_new (GDK_FOCUS_CHANGE);
163163
164 gdk_keyboard_ungrab (GDK_CURRENT_TIME);
165
166 gdk_keyboard_grab (widget->window, TRUE, GDK_CURRENT_TIME);
167
164 g_object_ref (widget);168 g_object_ref (widget);
165169
166 event->focus_change.type = GDK_FOCUS_CHANGE;170 event->focus_change.type = GDK_FOCUS_CHANGE;
@@ -169,8 +173,6 @@
169173
170 gtk_widget_event (widget, event);174 gtk_widget_event (widget, event);
171175
172 g_object_notify (G_OBJECT (widget), "has-focus");
173
174 g_object_unref (widget);176 g_object_unref (widget);
175 gdk_event_free (event);177 gdk_event_free (event);
176}178}
@@ -181,13 +183,10 @@
181{183{
182 GtkWidget *entry = IDO_ENTRY_MENU_ITEM (widget)->priv->entry;184 GtkWidget *entry = IDO_ENTRY_MENU_ITEM (widget)->priv->entry;
183185
186 ido_entry_menu_item_send_focus_change (widget, TRUE);
187
184 if (event->button == 1)188 if (event->button == 1)
185 {189 {
186 if (entry->window != NULL)
187 {
188 gdk_window_raise (entry->window);
189 }
190
191 if (!gtk_widget_has_focus (entry))190 if (!gtk_widget_has_focus (entry))
192 {191 {
193 gtk_widget_grab_focus (entry);192 gtk_widget_grab_focus (entry);

Subscribers

People subscribed via source and target branches

to all changes: