Code review comment for lp:~bratsche/appmenu-gtk/parent-tracking

Revision history for this message
Ted Gould (ted) wrote :

I'm trying to figure if we need a weak ref on the parent. I think that it's okay as you're not moving menuitems around to different parents anywhere else in appmenu-gtk. But, I think you should probably put a comment in for when something changes :)

review: Approve

« Back to merge proposal