Merge lp:~brandontschaefer/unity/switcher-detail-mode-fix-last-active into lp:unity
Proposed by
Brandon Schaefer
Status: | Merged |
---|---|
Approved by: | Brandon Schaefer |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2524 |
Proposed branch: | lp:~brandontschaefer/unity/switcher-detail-mode-fix-last-active |
Merge into: | lp:unity |
Diff against target: |
66 lines (+19/-2) 3 files modified
launcher/SwitcherModel.cpp (+3/-1) launcher/SwitcherModel.h (+2/-0) tests/autopilot/unity/tests/test_switcher.py (+14/-1) |
To merge this branch: | bzr merge lp:~brandontschaefer/unity/switcher-detail-mode-fix-last-active |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christopher Lee (community) | Approve | ||
Review via email: mp+116792@code.launchpad.net |
Commit message
The switcher in detail mode will now focus the last active window, instead of the current one. If the current focus window activated the switcher.
Description of the change
=== Problem ===
When going into detail mode the switcher would focus its own window. This means Detail mode would no longer know if the window was currently active. So it would not swap the current window with the last active window.
This also cause detail mode to all of a sudden swap the first and second icon (very annoying)
=== Fix ===
Save the currently active icon type, so when we check if we need to swap icons we know which one it was.
=== Test ===
There is an AP test.
To post a comment you must log in.
The Jenkins job https:/ /jenkins. qa.ubuntu. com/job/ automerge- unity/965/ console reported an error when processing this lp:~brandontschaefer/unity/switcher-detail-mode-fix-last-active branch.
Not merging it.