Code review comment for lp:~brandontschaefer/unity/quicklist-close-super-open-dash

Hi,

34 + """When the quicklist is open and you open the dash:
35 + The quicklist should close then the dash must open.
36 +
37 + """

Please fix this docstring. "should" is a weasel word that implies ambiguity. I suggest a better docstring is something like:

"When a quicklist is open you must still be able to open the dash by pushing the Super key."""

39 + [calc_win1] = calc.get_windows()
40 + self.assertTrue(calc_win1.is_focused)

You don't need these two lines - you never use calc_win1, and we don't need to assert that the window is focused (that's not what we're testing).

45 + self.dash.ensure_visible()

If this succeeds you'll be leaving the dash open, which will cause the test to fail! Please add the following:

self.addCleanup(self.dash.ensure_hidden)

Other than that, looks good.