Code review comment for lp:~brandontschaefer/unity/mouse-click-outside-dash-closing-fix

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

Ah, before of general approval, it would be nice if you'd change the calls:

nux::Geometry on_top_geo = wm->GetWindowGeometry(top_xid);
nux::Geometry dash_geo = dash_controller_->GetInputWindowGeometry();

to use nux::Geometry const& instead.

« Back to merge proposal