Merge lp:~brandontschaefer/unity/lp1086988-fix-x-focus-dash-hud-xim into lp:unity
Status: | Merged |
---|---|
Approved by: | Andrea Azzarone |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2978 |
Proposed branch: | lp:~brandontschaefer/unity/lp1086988-fix-x-focus-dash-hud-xim |
Merge into: | lp:unity |
Diff against target: |
218 lines (+59/-27) 6 files modified
dash/DashController.cpp (+22/-9) dash/DashController.h (+4/-0) hud/HudController.cpp (+20/-8) hud/HudController.h (+3/-0) plugins/unityshell/src/unityshell.cpp (+10/-5) tests/autopilot/unity/tests/xim/test_gcin.py (+0/-5) |
To merge this branch: | bzr merge lp:~brandontschaefer/unity/lp1086988-fix-x-focus-dash-hud-xim |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrea Azzarone (community) | Approve | ||
PS Jenkins bot | continuous-integration | Pending | |
Review via email: mp+138617@code.launchpad.net |
Commit message
The Dash/HUD have X focus when open now, instead of the launcher.
Description of the change
=== Problem ===
When the Dash or Hud was open, the launcher would have X focus. This means events generated by X would think the launcher is focused. This causes problems when trying to use XIM, as it think the Launcher is generating events not the Dash or Hud, so XIM fails to work.
=== Fix ===
Make it re focus the key input for the dash or hud when an external application is opened when the Dash/Hud is open.
=== Test ===
Removing the explicit skip in XIM tests, as they all pass now, and skip correctly if no gcin is found.
Video showing hime (An input method) in action.
http://
Works here.