Code review comment for lp:~brandontschaefer/unity/ibus-daemon-workaroud-attempt3

Revision history for this message
Stephen M. Webb (bregma) wrote :

Python recommends you replace os.spawnlp() with subprocess.Popen().

Instead of waiting 5 seconds you could use ps to poll every second (up to some max, like 10 s) to see if the ibus daemon has started.

The processes won't become zombies if you use os.waitpid() to wait for the reaped children (Popen().pid could be useful here).

« Back to merge proposal