Merge lp:~brandontschaefer/unity/fix-896122 into lp:unity
Status: | Rejected |
---|---|
Rejected by: | Tim Penhey |
Proposed branch: | lp:~brandontschaefer/unity/fix-896122 |
Merge into: | lp:unity |
Diff against target: |
280 lines (+107/-21) 6 files modified
manual-tests/Launcher.txt (+54/-0) manual-tests/launcher.txt (+0/-11) plugins/unityshell/src/Launcher.cpp (+37/-2) plugins/unityshell/src/Launcher.h (+1/-0) plugins/unityshell/src/QuicklistView.cpp (+12/-7) plugins/unityshell/src/QuicklistView.h (+3/-1) |
To merge this branch: | bzr merge lp:~brandontschaefer/unity/fix-896122 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrea Azzarone (community) | Approve | ||
Sam Spilsbury (community) | Approve | ||
Review via email: mp+86848@code.launchpad.net |
Description of the change
Uses the window_focus_change signal to close the keynav when the focus is changed from the launcher; while still allowing the user to preform normal actions; such as moving a window or highlighting text etc.
Handles the quicklist problem by using a bool in the QuicklistView that gets set if the mouse is responsible for the call to QuicklistView:
The shortcuts get handled in Launcher:
Needs test cases.