Code review comment for lp:~brandontschaefer/unity/fix-711199

Revision history for this message
Tim Penhey (thumper) wrote :

Why check for
  if (active_lens_view_->lens())
at the start of DashView::OnSearchFinished?
Small style issue, no space before (hints).

plese use:
  nux::color::White
instead of:
  nux::Color(1.0f,1.0f,1.0f,1.0f)

Instead of using += on a std::string, use a string stream.

#include <sstream>

std::stringstream sout;

sout << "<span size='larger' weight='bold'>";
//...
sout << g_variant_get_string(it->second, NULL);
//...
sout << "Sorry, there is nothing that matches your search.";
//...
sout << "</span>";

LOG_DEBUG(logger) << "The no-result-hint is: " << sout.str();

no_results_->SetText(sout.str());

How does the normal results view get shown again?

review: Needs Fixing

« Back to merge proposal