Code review comment for lp:~brandontschaefer/unity/ap-panel-test-fix

Revision history for this message
Sebastien Bacher (seb128) wrote :

Seems like that commit created issues, at least one of the test is failing to pass on today's runs:

http://10.97.0.1:8080/job/ps-generic-autopilot-release-testing/label=autopilot-ati/18/testReport/unity.tests.test_panel/PanelWindowButtonsTests/test_window_buttons_active_inactive_states_Single_Monitor_/

"Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/unity/tests/test_panel.py", line 541, in test_window_buttons_active_inactive_states
    unmaximize = self.unity.dash.view.window_buttons.unmaximize
  File "/usr/lib/python2.7/dist-packages/unity/emulators/dash.py", line 191, in window_buttons
    return self.__get_window_buttons().window_buttons()
  File "/usr/lib/python2.7/dist-packages/unity/emulators/dash.py", line 164, in __get_window_buttons
    assert(len(buttons) == 1)
AssertionError"

seems like
"buttons = self.get_children_by_type(OverlayWindowButtons)"

returns [] (tested on a local run, it's happening in a consistant way)

« Back to merge proposal