Code review comment for lp:~brandontschaefer/mir/usr-mir-window-placement

36 MirSurfacePlacementEvent const* mir_event_get_surface_placement_event(MirEvent const* event);
37

Forgot to follow 'deprecated' in a comment as a reminder.
-------------------------------------------------------

71 + * Authored by: Alan Griffiths <email address hidden>
72

your name should be added?
-------------------------------------------------------

87 +typedef struct MirSurfacePlacementEvent MirWindowPlacementEvent;
88 +

Must not be typedef'ed again... Just include the right file where it was originally typedefed.
-------------------------------------------------------

132 -MirRectangle mir_surface_placement_get_relative_position(MirSurfacePlacementEvent const* event) MIR_HANDLE_EVENT_EXCEPTION(
133 +MirRectangle mir_window_placement_get_relative_position(MirWindowPlacementEvent const* event) MIR_HANDLE_EVENT_EXCEPTION(

Must not replace the old function. Just call the new function from the old