Mir

Code review comment for lp:~brandontschaefer/mir/server-gamma-kms

Revision history for this message
Kevin DuBois (kdub) wrote :

+ red_ (bytes_red.size() / 2),
+ green_(bytes_red.size() / 2),
+ blue_ (bytes_red.size() / 2)

spacing, plus would be better to use sizeof() instead of just 2.

+ DisplayGamma(std::string const& bytes_red,
+ std::string const& bytes_green,
+ std::string const& bytes_blue);
Seeing as this is in the public API, the constructors should be generic, and IIRC from IRC, the string constructor was to help with unflattening the IPC. It might just be better to have it take 3 vectors, and check their sizes.

« Back to merge proposal