Mir

Code review comment for lp:~brandontschaefer/mir/no-android-input-channel

Revision history for this message
Kevin DuBois (kdub) wrote :

nit:
+ mir::Fd server_fd_;
no need for mir::, already in correct namespace

Diff size would be much reduced with bzr mv. If its not too much trouble, it could still be done.

The rest looks alright to me.

nb:
+mi::Channel::Channel()
Although I don't think I see an opportunity for an exception to be thrown between the socketpair and setting mir::Fd (only C functions are used), in general the fd's should be put in the RAII wrapper right after the resource is acquired for exception safety.

review: Approve

« Back to merge proposal