> Ok by me.
>
> Nits:
>
> 100 + # We're being naughty deleting this function without bumping
> soname, but we won't get caught.
> 101 + # mir_input_device_state_event_device_pressed_keys;
>
> Why comment it out? Why not just delete it?
> ------------------------------------------------------------------------------
Since we are doing something quite bad, it seemed like a good idea to comment that out and leave a comment to why it was delete for now.
> -
>
> 150 + // Client API usage is deprecated, remove this when we can
> 151 uint32_t const* device_pressed_keys(size_t index) const;
>
> Why not now? you seem to have done away with the only instance of it. Is it so
> we do not break the common ABI?
For right now yes, avoiding the common ABI break until we figure out... though its in a src/include/common does this break ABI?
> Ok by me. device_ state_event_ device_ pressed_ keys; ------- ------- ------- ------- ------- ------- ------- ------- ------- ------- - pressed_ keys(size_ t index) const;
>
> Nits:
>
> 100 + # We're being naughty deleting this function without bumping
> soname, but we won't get caught.
> 101 + # mir_input_
>
> Why comment it out? Why not just delete it?
> -------
Since we are doing something quite bad, it seemed like a good idea to comment that out and leave a comment to why it was delete for now.
> -
>
> 150 + // Client API usage is deprecated, remove this when we can
> 151 uint32_t const* device_
>
> Why not now? you seem to have done away with the only instance of it. Is it so
> we do not break the common ABI?
For right now yes, avoiding the common ABI break until we figure out... though its in a src/include/common does this break ABI?