Mir

Code review comment for lp:~brandontschaefer/mir/client-api-apply-remove-display-config

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> > *Needs Information*
> >
> > I'm not entirely sure about the direction here. Surely the "old
> configuration
> > API" is the set of functions using MirDisplayConfiguration*?
>
> Yes
>
> >
> > In which case, you've missed:
> >
> > MirBlob* mir_blob_from_display_configuration(MirDisplayConfiguration*
> > configuration);
> >
> > and
> >
> > MirDisplayConfiguration* mir_blob_to_display_configuration(MirBlob* blob);
> >
>
> Hmm yes, there is no blob for MirDisplayConfig

AFAICS the MP is OK except the commit message needs to say "Add two of the missing functions needed to remove the old display configuration API."

Regarding the blobs: don't forget that blobs may have been created by the legacy API - we may need to support loading both versions (if they differ).

« Back to merge proposal