> > *Needs Information*
> >
> > I'm not entirely sure about the direction here. Surely the "old
> configuration
> > API" is the set of functions using MirDisplayConfiguration*?
>
> Yes
>
> >
> > In which case, you've missed:
> >
> > MirBlob* mir_blob_from_display_configuration(MirDisplayConfiguration*
> > configuration);
> >
> > and
> >
> > MirDisplayConfiguration* mir_blob_to_display_configuration(MirBlob* blob);
> >
>
> Hmm yes, there is no blob for MirDisplayConfig
AFAICS the MP is OK except the commit message needs to say "Add two of the missing functions needed to remove the old display configuration API."
Regarding the blobs: don't forget that blobs may have been created by the legacy API - we may need to support loading both versions (if they differ).
> > *Needs Information* guration* ? from_display_ configuration( MirDisplayConfi guration* guration* mir_blob_ to_display_ configuration( MirBlob* blob);
> >
> > I'm not entirely sure about the direction here. Surely the "old
> configuration
> > API" is the set of functions using MirDisplayConfi
>
> Yes
>
> >
> > In which case, you've missed:
> >
> > MirBlob* mir_blob_
> > configuration);
> >
> > and
> >
> > MirDisplayConfi
> >
>
> Hmm yes, there is no blob for MirDisplayConfig
AFAICS the MP is OK except the commit message needs to say "Add two of the missing functions needed to remove the old display configuration API."
Regarding the blobs: don't forget that blobs may have been created by the legacy API - we may need to support loading both versions (if they differ).