Mir

Code review comment for lp:~brandontschaefer/mir/client-api-apply-remove-display-config

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

> *Needs Information*
>
> I'm not entirely sure about the direction here. Surely the "old configuration
> API" is the set of functions using MirDisplayConfiguration*?

Yes

>
> In which case, you've missed:
>
> MirBlob* mir_blob_from_display_configuration(MirDisplayConfiguration*
> configuration);
>
> and
>
> MirDisplayConfiguration* mir_blob_to_display_configuration(MirBlob* blob);
>

Hmm yes, there is no blob for MirDisplayConfig

> (Yes, I know these have the intended form of the "future" API, but AIUI they
> have to go before we can eliminate MirDisplayConfiguration* and rename
> MirDisplayConfig* as planned or confusion will ensue.)
>
> Can you (or other reviewers) clarify?

Ill get this doubled checked as this is the main goal of this branch to be able to deprecate the old display config way!

« Back to merge proposal