Mir

Code review comment for lp:~brandontschaefer/mir/client-api-apply-remove-display-config

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Specifically, according to your own comments we need to rename display_config_ to display_configuration, and here you are proposing the opposite of that, actually making the problem worse.

If you believe that MirDisplayConfig and _display_config is the way forward then you should retract your review of:
    https://code.launchpad.net/~vanvugt/mir/mir-display-config-header/+merge/311246

If not then you should change "config" to "configuration" here. I know we're in limbo right now with the old API hanging around, but we should reject changes like this that make the problem worse, if indeed the team believes that the word "config" is the problem.

Brandon Schaefer (brandontschaefer) wrote on 2016-12-10:
I would like to think we were all doing our jobs. Im still in favour of MirDisplayConfiguration. 6 characters isnt *to* many extra characters to type. Yes it break ABI, yes it'll be a bit more work. We are already planning on breaking the ABI. I dont see a reason we should avoid this when a majority of us agreed on a name already.

review: Needs Fixing

« Back to merge proposal