Mir

Code review comment for lp:~brandontschaefer/mir/client-api-apply-remove-display-config

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Although I still prefer "config" over "configuration", it should be said.

Regardless, the type name and the function names should match up. Either:
   MirDisplayConfig
   mir..._display_config_...()
or
   MirDisplayConfiguration
   mir..._display_configuration_...()

For a more clear way forward that gets us closer to this ideal, I have already proposed:
   https://code.launchpad.net/~vanvugt/mir/mir-display-config-header/+merge/311246
which you should probably revisit. Either fix this branch or retract your review of my branch.

review: Needs Fixing

« Back to merge proposal