Mir

Code review comment for lp:~brandontschaefer/mir/add-client-confine-pointer-spec

Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Would be better if 'mir_pointer_unconfined' was the first item in the enum. That way, if we decide to add things like mir_pointer_confined_to_region, the list will continue to look sensible.

33 +typedef enum MirPointerConfinementState
34 +{
35 + mir_pointer_confined_to_surface,
36 + mir_pointer_unconfined
37 +} MirPointerConfinementState;
--------------------------------------------

s/can_set_pointer_confienment/can_set_pointer_confinement

165 +TEST_F(ClientLibrary, can_set_pointer_confienment)

review: Needs Fixing

« Back to merge proposal