Code review comment for lp:~brandontschaefer/compiz/restore-orig-pos-lp.892012-fix

Revision history for this message
MC Return (mc-return) wrote :

Sami, for most of the other Grid troubles we already have solutions. I just had no time to implement those yet and wanted this to land first also.
For example we use xwc in Grid twice without initialization (Coverity bugs already triaged).
Also we still have the wrong positioning of the mousepointer when wobbly is enabled, for which we engineered a hack or have analyzed other workarounds in our minds already.
The thing with the semi-maximized windows ignoring the do-not-restore-window-size setting is something that seems simple to fix as well.
The thing with gnome-terminal acting weird has to be analyzed, but my idea is that it *could* have to do with gnome-terminal character-size settings or with uninitialized stuff, because it happens *sometimes* only.
We should find out if it happens with xterm also to exclude that it is gnome-terminal specific for example...

One thing to note also here is that a Grid-maximize via "Put Center" is *not* the same as a Compiz+Unity+globalmenu Maximize as the window border will still be intact when former is used, which could also be responsible for strange behaviour (needs investigation still, just an idea)...

Everything that just happens "sometimes" needs special attention as this is something that should never happen with good code.

Overall I think that Grid currently acts better than ever before, has more features and the fact that Compiz finally learned how to snap off horizontally maximized windows is a big step forward. We are on a good way :)

Just my 2 cents.
Just my 5 cent.

« Back to merge proposal