Code review comment for lp:~brandontschaefer/compiz/restore-orig-pos-lp.892012-fix

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

On the right track, a few suggestions:

1. It might be good to leave saveWc ().x / y / width / height alone unless they were not already set (eg, saveMask () & CWX | CWY | CWWidth | CWHeight)
2. Style Issues:

16 + else if (isGridVertMaximized)
17 + {

s/spaces/tab-4spaces/

Space needed between identifier and ()

Vertical whitespace needed between saveMask () assignment and saveWc () assignment if there is no horizontal alignment.

3. It might make sense to unset the CWY | CWHeight / CWX | CWWidth bits on the keyboard-placed window if the window is grabbed later (eg GridWindow::grabNotify)

review: Needs Fixing

« Back to merge proposal