Juju Charms Collection
rabbitmq-server package

Code review comment for lp:~brad-marshall/charms/trusty/rabbitmq-server/nagios-fixes-sync-charmhelpers

  1. Trusty Tahr (14.04)
  2. nagios-fixes-sync-charmhelpers
  3. Merge into trunk
Revision history for this message
Adam Israel (aisrael) wrote :

Hi Brad,

Thanks for your work on improving the rabbitmq-server charm. I reviewed the merge proposal and your changes look solid. There are issues with the unit tests upstream, and bugs have been opened against those. I don't see anything in this MP that would caused the test failures, so you have a +1 from me.

review: Approve

« Back to merge proposal