Code review comment for lp:~brad-marshall/charms/trusty/ntp/add-auto-peers

Revision history for this message
Charles Butler (lazypower) wrote :

I circled back and cleaned up the tests to pass.

Thanks for the contribution! Make sure that you backport the changes from tests/10-deploy-test.py into your branch before making the next revision or it will collide with whats currently included in TRUNK.

+1 LGTM. Thank you for taking the time to submit this fix for the charm store. We appreciate your work. I've merged this branch and it should be available in the charm store after the next ingestion.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.

review: Approve

« Back to merge proposal