Code review comment for lp:~brad-marshall/charms/trusty/ntp/add-auto-peers

Revision history for this message
Charles Butler (lazypower) wrote :

There's one fix I'd like to comment on with this branch.

It appears there's a bug in the setup routine that isn't installing amulet for the python version under test.

http://reports.vapour.ws/charm-test-details/charm-bundle-test-parent-214

I've pulled the tests and run them manually and while the dependency is present, I was unable to get a successful test run:

Traceback (most recent call last):
  File "/tmp/bundletester-s0XPw7/ntp/tests/10-deploy-test.py", line 98, in <module>
    configuration_file.index(ubuntu_0_public_address)

This returned on all tested substrates.

Once this is fixed up I'll be happy to approve and merge.

Thanks for all the hard work already @brad-marshall, I look forward to ack'ing this MP soon.

review: Needs Fixing

« Back to merge proposal