Juju Charms Collection
nagios package

Code review comment for lp:~brad-marshall/charms/trusty/nagios/add-extra-config-options

  1. Trusty Tahr (14.04)
  2. add-extra-config-options
  3. Merge into trunk
Revision history for this message
Cory Johns (johnsca) wrote :

Brad,

The problem with race conditions is that they are inherently difficult to reproduce, and this one would depend heavily on the environment in which they are run, so I'm not at all surprised that you weren't seeing the same failure I was.

The 30s wait, along with some recent improvements to Amulet, seems to be sufficient and the test is passing for me. I'd really like to see the other test failures resolved, but as I said before, we can call that out of scope for this change. So this gets my +1 and I'll get it merged today.

Apologies for the delay on the review.

review: Approve

« Back to merge proposal