Juju Charms Collection
mongodb package

Code review comment for lp:~brad-marshall/charms/trusty/mongodb/add-nrpe-checks

  1. Trusty Tahr (14.04)
  2. add-nrpe-checks
  3. Merge into trunk
Revision history for this message
Adam Israel (aisrael) wrote :

Hi Brad,

I had the opportunity to review your merge proposal today. Thanks for all of your work on this so far.

I initially ran into a merge conflict with your branch against trunk, related to charm-helpers-sync.yaml. I resolved those to continue testing.

Of seven unit tests, make lint is failing:

hooks/hooks.py:1123:80: E501 line too long (92 > 79 characters)
hooks/hooks.py:1144:18: E251 unexpected spaces around keyword / parameter equals
hooks/hooks.py:1144:20: E251 unexpected spaces around keyword / parameter equals

Thanks again for your work on this! With those minor fixes, I don't see any other blockers to merging this proposal.

review: Needs Fixing

« Back to merge proposal