Merge lp:~brad-marshall/charms/trusty/keystone/haproxy-add-timeout into lp:~openstack-charmers-archive/charms/trusty/keystone/next

Proposed by Brad Marshall
Status: Rejected
Rejected by: James Page
Proposed branch: lp:~brad-marshall/charms/trusty/keystone/haproxy-add-timeout
Merge into: lp:~openstack-charmers-archive/charms/trusty/keystone/next
Diff against target: 19 lines (+12/-0)
1 file modified
config.yaml (+12/-0)
To merge this branch: bzr merge lp:~brad-marshall/charms/trusty/keystone/haproxy-add-timeout
Reviewer Review Type Date Requested Status
Liam Young (community) Disapprove
Review via email: mp+279709@code.launchpad.net

Description of the change

Expose haproxy server and client timeouts via config.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #15034 keystone-next for brad-marshall mp279709
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/15034/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #14024 keystone-next for brad-marshall mp279709
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/14024/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #8197 keystone-next for brad-marshall mp279709
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/8197/

Revision history for this message
Liam Young (gnuoy) wrote :

thedacs branch has landed into /next which supercedes this one, but thank you for taking the time to raise the mp.

review: Disapprove

Unmerged revisions

193. By Brad Marshall

[brad-marshall] Expose haproxy server and client timeouts via config.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2015-10-07 16:20:36 +0000
+++ config.yaml 2015-12-07 00:36:15 +0000
@@ -308,3 +308,15 @@
308 wait for you to execute the openstack-upgrade action for this charm on308 wait for you to execute the openstack-upgrade action for this charm on
309 each unit. If False it will revert to existing behavior of upgrading309 each unit. If False it will revert to existing behavior of upgrading
310 all units on config change.310 all units on config change.
311 haproxy-server-timeout:
312 type: int
313 default:
314 description: |
315 Server timeout configuration in ms for haproxy, used in HA configurations.
316 If not provided, default value of 30000ms is used.
317 haproxy-client-timeout:
318 type: int
319 default:
320 description: |
321 Client timeout configuration in ms for haproxy, used in HA
322 configurations. If not provided, default value of 30000ms is used.

Subscribers

People subscribed via source and target branches