Merge lp:~brad-marshall/charms/trusty/cinder/haproxy-add-timeout into lp:~openstack-charmers-archive/charms/trusty/cinder/next

Proposed by Brad Marshall
Status: Needs review
Proposed branch: lp:~brad-marshall/charms/trusty/cinder/haproxy-add-timeout
Merge into: lp:~openstack-charmers-archive/charms/trusty/cinder/next
Diff against target: 19 lines (+12/-0)
1 file modified
config.yaml (+12/-0)
To merge this branch: bzr merge lp:~brad-marshall/charms/trusty/cinder/haproxy-add-timeout
Reviewer Review Type Date Requested Status
Liam Young (community) Disapprove
Review via email: mp+279708@code.launchpad.net

Description of the change

Expose haproxy server and client timeouts via config.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #14020 cinder-next for brad-marshall mp279708
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/14020/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #15033 cinder-next for brad-marshall mp279708
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/15033/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #8196 cinder-next for brad-marshall mp279708
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/13792369/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8196/

Revision history for this message
Liam Young (gnuoy) wrote :

thedacs branch has landed into /next which supercedes this one, but thank you for taking the time to raise the mp.

review: Disapprove

Unmerged revisions

136. By Brad Marshall

[brad-marshall] Expose haproxy server and client timeouts via config.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2015-08-31 16:25:22 +0000
+++ config.yaml 2015-12-07 00:43:23 +0000
@@ -292,3 +292,15 @@
292 wait for you to execute the openstack-upgrade action for this charm on292 wait for you to execute the openstack-upgrade action for this charm on
293 each unit. If False it will revert to existing behavior of upgrading293 each unit. If False it will revert to existing behavior of upgrading
294 all units on config change.294 all units on config change.
295 haproxy-server-timeout:
296 type: int
297 default:
298 description: |
299 Server timeout configuration in ms for haproxy, used in HA configurations.
300 If not provided, default value of 30000ms is used.
301 haproxy-client-timeout:
302 type: int
303 default:
304 description: |
305 Client timeout configuration in ms for haproxy, used in HA
306 configurations. If not provided, default value of 30000ms is used.

Subscribers

People subscribed via source and target branches