charm-storage-connector:defer-service-restarts-integration

Branch merges

Propose for merging

Merged into charm-storage-connector:master at revision 0ac891951896d6133ed80e7f2759f7f403b99918

Andrea Ieri: Approve on 2023-03-13

🤖 prod-jenkaas-bootstack (community): Approve (continuous-integration) on 2023-03-13

BootStack Reviewers: Pending requested 2023-03-13

Diff: 1433 lines (+768/-154)

11 files modified

README.md (+9/-10)
actions.yaml (+32/-3)
config.yaml (+25/-18)
metadata.yaml (+2/-2)
requirements.txt (+4/-2)
src/charm.py (+232/-72)
tests/functional/storage-connector-func-tests/setup.py (+48/-0)
tests/functional/storage-connector-func-tests/tests.py (+98/-31)
tests/functional/tests/tests.yaml (+1/-0)
tests/unit/test_charm.py (+312/-11)
tox.ini (+5/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

37b83ef... by Tianqi Xiao on 2023-03-10

Remove service related BlockStatus setter and pin ops framework version

Merged branch ~txiao/charm-storage-connector:iscsi-discovery-and-login

7940b41... by Tianqi Xiao on 2023-03-07

Add logic to allow auto discovery and login after iscsi service restart

6fb1834... by Tianqi Xiao on 2023-02-02

Add defer methods for better handling service restarts

- Make use of charmhelpers policy_rcd script to block automatic stop, restarts, try-restarts action for all charm managed services, including iscsid open-iscsi, and multipathd.
- Handles deferred restarts triggered by both charm and non-charm events
- Display the queue of deferred service restarts in charm status message
and periodic updates
- Add `enable-auto-restarts` config option to give user option to allow automatic restarts action if needed (the default value is False)
- Add `restart-services` action to restart charm managed service. The
operator can choose to restart either all deferred services or a specific
set of services.
- Add `show-deferred-restarts` action to show all deferred restart events
with the timestamp and reason
- Add `iscsi-discovery-and-login` action that allow operator to manually
run iscsiadm discovery and login when needed
- Remove `restart-iscsi-services` action in favor of the new
`restart-services` action
- Better handling different types of iscsi discovery and login failures.
If failed because session already present, ignore the error; otherwise
change charm status to blocked.
- Add unittests and functional tests for the new and modified methods
- Rework functional tests logic to make each test case independent of each other.

Merged branch ~txiao/charm-storage-connector:defer_restart

fd35567... by Mert Kirpici on 2022-11-29

Close LP #1998094

Reviewed-on: https://code.launchpad.net/~mertkirpici/charm-storage-connector/+git/charm-storage-connector/+merge/433728
Reviewed-by: Ramesh Sattaru <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Erhan Sunar <email address hidden>

8f56548... by Mert Kirpici on 2022-11-28

tox: move flake8 config comments to new line

flake8 6.0.0 does not like it when the inline comments are on the same
line as the ignored rule.

Works-on: 1998094
Signed-off-by: Mert Kırpıcı <email address hidden>

01ffcc9... by Mert Kirpici on 2022-10-15

Close LP #1966618

Reviewed-on: https://code.launchpad.net/~mertkirpici/charm-storage-connector/+git/charm-storage-connector/+merge/431367
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Erhan Sunar <email address hidden>

2b20d3f... by Mert Kirpici on 2022-10-12

tests/unit/nrpe: test non default check value

Works-on: 1966618
Signed-off-by: Mert Kırpıcı <email address hidden>

abfb8e8... by Mert Kirpici on 2022-10-12

nrpe: remove nagios user creation

Signed-off-by: Mert Kırpıcı <email address hidden>

b9500cc... by Mert Kirpici on 2022-10-12

Partial LP #1966618

Reviewed-on: https://code.launchpad.net/~mertkirpici/charm-storage-connector/+git/charm-storage-connector/+merge/430920
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Erhan Sunar <email address hidden>

e29e1b3... by Mert Kirpici on 2022-10-10

charm: implement nrpe interface

Works-on: 1966618
Signed-off-by: Mert Kırpıcı <email address hidden>