Merge ~mertkirpici/charm-storage-connector:lp/1998094 into charm-storage-connector:master

Proposed by Mert Kirpici
Status: Merged
Approved by: Ramesh Sattaru
Approved revision: 8f56548e33ffedc2260482441a0a18e4f3080ae1
Merged at revision: fd35567f8cda45c2b6abea9268673e3a55007692
Proposed branch: ~mertkirpici/charm-storage-connector:lp/1998094
Merge into: charm-storage-connector:master
Diff against target: 14 lines (+2/-1)
1 file modified
tox.ini (+2/-1)
Reviewer Review Type Date Requested Status
Ramesh Sattaru (community) Approve
Erhan Sunar (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Review via email: mp+433728@code.launchpad.net

Commit message

Close LP #1998094

Description of the change

flake8 6.0.0 does not like it when the inline comments are on the same
line as the ignored rule.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Erhan Sunar (esunar) :
review: Approve
Revision history for this message
Ramesh Sattaru (rameshcan) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision fd35567f8cda45c2b6abea9268673e3a55007692

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tox.ini b/tox.ini
2index a763f7e..5c8e284 100644
3--- a/tox.ini
4+++ b/tox.ini
5@@ -60,7 +60,8 @@ deps =
6
7 [flake8]
8 ignore =
9- W504 # line break after binary operator
10+ # line break after binary operator
11+ W504
12 exclude =
13 .git,
14 __pycache__,

Subscribers

People subscribed via source and target branches

to all changes: