Merge lp:~boiko/messaging-app/fix_mouse_back_button into lp:messaging-app

Proposed by Gustavo Pichorim Boiko
Status: Superseded
Proposed branch: lp:~boiko/messaging-app/fix_mouse_back_button
Merge into: lp:messaging-app
Diff against target: 78 lines (+11/-9)
2 files modified
src/qml/Messages.qml (+8/-6)
src/qml/NewRecipientPage.qml (+3/-3)
To merge this branch: bzr merge lp:~boiko/messaging-app/fix_mouse_back_button
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+288966@code.launchpad.net

This proposal has been superseded by a proposal from 2016-03-16.

Commit message

Hide and disable the Section object when it is not in use.

Description of the change

Hide and disable the Section object when it is not in use.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
530. By Gustavo Pichorim Boiko

Merge parent branch.

531. By Gustavo Pichorim Boiko

Adapt to parent branch.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/qml/Messages.qml'
--- src/qml/Messages.qml 2016-02-23 15:07:46 +0000
+++ src/qml/Messages.qml 2016-03-16 23:28:13 +0000
@@ -1,5 +1,5 @@
1/*1/*
2 * Copyright 2012-2015 Canonical Ltd.2 * Copyright 2012-2016 Canonical Ltd.
3 *3 *
4 * This file is part of messaging-app.4 * This file is part of messaging-app.
5 *5 *
@@ -477,12 +477,14 @@
477 flickable: null477 flickable: null
478478
479 Sections {479 Sections {
480 id: sections480 id: headerSections
481 anchors {481 anchors {
482 left: parent.left482 left: parent.left
483 leftMargin: units.gu(2)483 leftMargin: units.gu(2)
484 bottom: parent.bottom484 bottom: parent.bottom
485 }485 }
486 visible: headerSections.model.length > 1
487 enabled: visible
486 model: getSectionsModel()488 model: getSectionsModel()
487 selectedIndex: getSelectedIndex()489 selectedIndex: getSelectedIndex()
488 onSelectedIndexChanged: {490 onSelectedIndexChanged: {
@@ -492,7 +494,7 @@
492 }494 }
493 }495 }
494496
495 extension: sections.model.length > 1 ? sections : null497 extension: headerSections.model.length > 1 ? headerSections : null
496498
497 leadingActionBar {499 leadingActionBar {
498 id: leadingBar500 id: leadingBar
@@ -756,8 +758,8 @@
756 // force reevaluation758 // force reevaluation
757 messages.account = Qt.binding(getCurrentAccount)759 messages.account = Qt.binding(getCurrentAccount)
758 messages.phoneAccount = Qt.binding(isPhoneAccount)760 messages.phoneAccount = Qt.binding(isPhoneAccount)
759 head.sections.model = Qt.binding(getSectionsModel)761 headerSections.model = Qt.binding(getSectionsModel)
760 head.sections.selectedIndex = Qt.binding(getSelectedIndex)762 headerSections.selectedIndex = Qt.binding(getSelectedIndex)
761 }763 }
762 }764 }
763765
@@ -1152,7 +1154,7 @@
11521154
1153 if (messages.account && messages.accountId == "") {1155 if (messages.account && messages.accountId == "") {
1154 messages.accountId = messages.account.accountId1156 messages.accountId = messages.account.accountId
1155 messages.head.sections.selectedIndex = Qt.binding(getSelectedIndex)1157 headerSections.selectedIndex = Qt.binding(getSelectedIndex)
1156 }1158 }
11571159
1158 var newAttachments = []1160 var newAttachments = []
11591161
=== modified file 'src/qml/NewRecipientPage.qml'
--- src/qml/NewRecipientPage.qml 2016-02-01 20:10:42 +0000
+++ src/qml/NewRecipientPage.qml 2016-03-16 23:28:13 +0000
@@ -1,5 +1,5 @@
1/*1/*
2 * Copyright 2012, 2013, 2014 Canonical Ltd.2 * Copyright 2012-2016 Canonical Ltd.
3 *3 *
4 * This file is part of messaging-app.4 * This file is part of messaging-app.
5 *5 *
@@ -213,9 +213,9 @@
213 }213 }
214214
215 Connections {215 Connections {
216 target: newRecipientPage.head.sections216 target: headerSections
217 onSelectedIndexChanged: {217 onSelectedIndexChanged: {
218 switch (newRecipientPage.head.sections.selectedIndex) {218 switch (headerSections.selectedIndex) {
219 case 0:219 case 0:
220 contactList.showAllContacts()220 contactList.showAllContacts()
221 break;221 break;

Subscribers

People subscribed via source and target branches