Merge lp:~boiko/messaging-app/fix_mouse_back_button into lp:messaging-app

Proposed by Gustavo Pichorim Boiko
Status: Superseded
Proposed branch: lp:~boiko/messaging-app/fix_mouse_back_button
Merge into: lp:messaging-app
Diff against target: 78 lines (+11/-9)
2 files modified
src/qml/Messages.qml (+8/-6)
src/qml/NewRecipientPage.qml (+3/-3)
To merge this branch: bzr merge lp:~boiko/messaging-app/fix_mouse_back_button
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+288966@code.launchpad.net

This proposal has been superseded by a proposal from 2016-03-16.

Commit message

Hide and disable the Section object when it is not in use.

Description of the change

Hide and disable the Section object when it is not in use.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
530. By Gustavo Pichorim Boiko

Merge parent branch.

531. By Gustavo Pichorim Boiko

Adapt to parent branch.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/Messages.qml'
2--- src/qml/Messages.qml 2016-02-23 15:07:46 +0000
3+++ src/qml/Messages.qml 2016-03-16 23:28:13 +0000
4@@ -1,5 +1,5 @@
5 /*
6- * Copyright 2012-2015 Canonical Ltd.
7+ * Copyright 2012-2016 Canonical Ltd.
8 *
9 * This file is part of messaging-app.
10 *
11@@ -477,12 +477,14 @@
12 flickable: null
13
14 Sections {
15- id: sections
16+ id: headerSections
17 anchors {
18 left: parent.left
19 leftMargin: units.gu(2)
20 bottom: parent.bottom
21 }
22+ visible: headerSections.model.length > 1
23+ enabled: visible
24 model: getSectionsModel()
25 selectedIndex: getSelectedIndex()
26 onSelectedIndexChanged: {
27@@ -492,7 +494,7 @@
28 }
29 }
30
31- extension: sections.model.length > 1 ? sections : null
32+ extension: headerSections.model.length > 1 ? headerSections : null
33
34 leadingActionBar {
35 id: leadingBar
36@@ -756,8 +758,8 @@
37 // force reevaluation
38 messages.account = Qt.binding(getCurrentAccount)
39 messages.phoneAccount = Qt.binding(isPhoneAccount)
40- head.sections.model = Qt.binding(getSectionsModel)
41- head.sections.selectedIndex = Qt.binding(getSelectedIndex)
42+ headerSections.model = Qt.binding(getSectionsModel)
43+ headerSections.selectedIndex = Qt.binding(getSelectedIndex)
44 }
45 }
46
47@@ -1152,7 +1154,7 @@
48
49 if (messages.account && messages.accountId == "") {
50 messages.accountId = messages.account.accountId
51- messages.head.sections.selectedIndex = Qt.binding(getSelectedIndex)
52+ headerSections.selectedIndex = Qt.binding(getSelectedIndex)
53 }
54
55 var newAttachments = []
56
57=== modified file 'src/qml/NewRecipientPage.qml'
58--- src/qml/NewRecipientPage.qml 2016-02-01 20:10:42 +0000
59+++ src/qml/NewRecipientPage.qml 2016-03-16 23:28:13 +0000
60@@ -1,5 +1,5 @@
61 /*
62- * Copyright 2012, 2013, 2014 Canonical Ltd.
63+ * Copyright 2012-2016 Canonical Ltd.
64 *
65 * This file is part of messaging-app.
66 *
67@@ -213,9 +213,9 @@
68 }
69
70 Connections {
71- target: newRecipientPage.head.sections
72+ target: headerSections
73 onSelectedIndexChanged: {
74- switch (newRecipientPage.head.sections.selectedIndex) {
75+ switch (headerSections.selectedIndex) {
76 case 0:
77 contactList.showAllContacts()
78 break;

Subscribers

People subscribed via source and target branches