Merge lp:~boiko/dialer-app/rtm-remove_multiple_entries into lp:dialer-app/rtm-14.09

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Bill Filler
Approved revision: 249
Merged at revision: 249
Proposed branch: lp:~boiko/dialer-app/rtm-remove_multiple_entries
Merge into: lp:dialer-app/rtm-14.09
Diff against target: 71 lines (+13/-12)
2 files modified
src/qml/HistoryPage/HistoryDetailsPage.qml (+3/-5)
src/qml/HistoryPage/HistoryPage.qml (+10/-7)
To merge this branch: bzr merge lp:~boiko/dialer-app/rtm-remove_multiple_entries
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+245943@code.launchpad.net

Commit message

Remove multiple entries all at once instead of using multiple calls.

Description of the change

Remove multiple entries all at once instead of using multiple calls.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/qml/HistoryPage/HistoryDetailsPage.qml'
--- src/qml/HistoryPage/HistoryDetailsPage.qml 2014-12-16 01:39:49 +0000
+++ src/qml/HistoryPage/HistoryDetailsPage.qml 2015-01-09 12:05:45 +0000
@@ -1,5 +1,5 @@
1/*1/*
2 * Copyright 2014 Canonical Ltd.2 * Copyright 2014-2015 Canonical Ltd.
3 *3 *
4 * This file is part of dialer-app.4 * This file is part of dialer-app.
5 *5 *
@@ -73,9 +73,7 @@
73 iconName: "delete"73 iconName: "delete"
74 text: i18n.tr("Delete")74 text: i18n.tr("Delete")
75 onTriggered: {75 onTriggered: {
76 for (var i in events) {76 eventModel.removeEvents(events);
77 eventModel.removeEvent(events[i].accountId, events[i].threadId, events[i].eventId, events[i].type);
78 }
79 pageStack.pop();77 pageStack.pop();
80 }78 }
81 }79 }
@@ -244,7 +242,7 @@
244 text: i18n.tr("Delete")242 text: i18n.tr("Delete")
245 onTriggered: {243 onTriggered: {
246 // remove from the history service244 // remove from the history service
247 eventModel.removeEvent(modelData.accountId, modelData.threadId, modelData.eventId, modelData.type)245 eventModel.removeEvents([modelData]);
248246
249 // as this page only displays an array of events, we need to update manually247 // as this page only displays an array of events, we need to update manually
250 // the list of displayed events248 // the list of displayed events
251249
=== modified file 'src/qml/HistoryPage/HistoryPage.qml'
--- src/qml/HistoryPage/HistoryPage.qml 2014-12-08 12:47:23 +0000
+++ src/qml/HistoryPage/HistoryPage.qml 2015-01-09 12:05:45 +0000
@@ -1,5 +1,5 @@
1/*1/*
2 * Copyright 2012-2013 Canonical Ltd.2 * Copyright 2012-2015 Canonical Ltd.
3 *3 *
4 * This file is part of dialer-app.4 * This file is part of dialer-app.
5 *5 *
@@ -191,9 +191,15 @@
191 listModel: historyEventModel191 listModel: historyEventModel
192192
193 onSelectionDone: {193 onSelectionDone: {
194 var events = [];
194 for (var i=0; i < items.count; i++) {195 for (var i=0; i < items.count; i++) {
195 var event = items.get(i).model196 var eventGroup = items.get(i).model.events
196 historyEventModel.removeEvent(event.accountId, event.threadId, event.eventId, event.type)197 for (var j in eventGroup) {
198 events.push(eventGroup[j]);
199 }
200 }
201 if (events.length > 0) {
202 historyEventModel.removeEvents(events)
197 }203 }
198 }204 }
199 onIsInSelectionModeChanged: {205 onIsInSelectionModeChanged: {
@@ -308,10 +314,7 @@
308 iconName: "delete"314 iconName: "delete"
309 text: i18n.tr("Delete")315 text: i18n.tr("Delete")
310 onTriggered: {316 onTriggered: {
311 var events = model.events;317 historyEventModel.removeEvents(model.events)
312 for (var i in events) {
313 historyEventModel.removeEvent(events[i].accountId, events[i].threadId, events[i].eventId, events[i].type)
314 }
315 }318 }
316 }319 }
317 property bool knownNumber: participants[0] != "x-ofono-private" && participants[0] != "x-ofono-unknown"320 property bool knownNumber: participants[0] != "x-ofono-private" && participants[0] != "x-ofono-unknown"

Subscribers

People subscribed via source and target branches