Merge lp:~boiko/dialer-app/fix_text_overlap into lp:dialer-app

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 489
Merged at revision: 490
Proposed branch: lp:~boiko/dialer-app/fix_text_overlap
Merge into: lp:dialer-app
Diff against target: 28 lines (+3/-1)
1 file modified
src/qml/LiveCallPage/ConferenceCallDisplay.qml (+3/-1)
To merge this branch: bzr merge lp:~boiko/dialer-app/fix_text_overlap
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Tiago Salem Herrmann (community) Approve
Review via email: mp+277990@code.launchpad.net

Commit message

Fix the overlap between the contact label and the "private" button on conf calls.

Description of the change

Fix the overlap between the contact label and the "private" button on conf calls.

To post a comment you must log in.
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Looks good.
tested on the device and it works fine.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/qml/LiveCallPage/ConferenceCallDisplay.qml'
--- src/qml/LiveCallPage/ConferenceCallDisplay.qml 2015-09-07 15:40:45 +0000
+++ src/qml/LiveCallPage/ConferenceCallDisplay.qml 2015-11-19 13:30:33 +0000
@@ -65,6 +65,7 @@
65 anchors {65 anchors {
66 left: parent.left66 left: parent.left
67 leftMargin: units.gu(1)67 leftMargin: units.gu(1)
68 right: splitButton.left
68 verticalCenter: parent.verticalCenter69 verticalCenter: parent.verticalCenter
69 }70 }
70 text: {71 text: {
@@ -76,6 +77,7 @@
76 return contactWatcher.identifier;77 return contactWatcher.identifier;
77 }78 }
78 }79 }
80 elide: Text.ElideRight
79 }81 }
8082
81 backgroundIndicator: Rectangle {83 backgroundIndicator: Rectangle {
@@ -123,7 +125,7 @@
123 bottom: parent.bottom125 bottom: parent.bottom
124 right: durationLabel.left126 right: durationLabel.left
125 }127 }
126 width: callStatus.width + units.gu(2)128 width: visible ? callStatus.width + units.gu(2) : 0
127129
128 visible: !callManager.backgroundCall130 visible: !callManager.backgroundCall
129 onClicked: callEntry.splitCall()131 onClicked: callEntry.splitCall()

Subscribers

People subscribed via source and target branches