Merge lp:~boiko/dialer-app/fix_text_overlap into lp:dialer-app

Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 489
Merged at revision: 490
Proposed branch: lp:~boiko/dialer-app/fix_text_overlap
Merge into: lp:dialer-app
Diff against target: 28 lines (+3/-1)
1 file modified
src/qml/LiveCallPage/ConferenceCallDisplay.qml (+3/-1)
To merge this branch: bzr merge lp:~boiko/dialer-app/fix_text_overlap
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Tiago Salem Herrmann (community) Approve
Review via email: mp+277990@code.launchpad.net

Commit message

Fix the overlap between the contact label and the "private" button on conf calls.

Description of the change

Fix the overlap between the contact label and the "private" button on conf calls.

To post a comment you must log in.
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Looks good.
tested on the device and it works fine.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/LiveCallPage/ConferenceCallDisplay.qml'
2--- src/qml/LiveCallPage/ConferenceCallDisplay.qml 2015-09-07 15:40:45 +0000
3+++ src/qml/LiveCallPage/ConferenceCallDisplay.qml 2015-11-19 13:30:33 +0000
4@@ -65,6 +65,7 @@
5 anchors {
6 left: parent.left
7 leftMargin: units.gu(1)
8+ right: splitButton.left
9 verticalCenter: parent.verticalCenter
10 }
11 text: {
12@@ -76,6 +77,7 @@
13 return contactWatcher.identifier;
14 }
15 }
16+ elide: Text.ElideRight
17 }
18
19 backgroundIndicator: Rectangle {
20@@ -123,7 +125,7 @@
21 bottom: parent.bottom
22 right: durationLabel.left
23 }
24- width: callStatus.width + units.gu(2)
25+ width: visible ? callStatus.width + units.gu(2) : 0
26
27 visible: !callManager.backgroundCall
28 onClicked: callEntry.splitCall()

Subscribers

People subscribed via source and target branches