Merge lp:~bluesabre/xubuntu-default-settings/lightdm-gtk-greeter-updates into lp:~xubuntu-dev/xubuntu-default-settings/trunk

Proposed by Sean Davis
Status: Merged
Merged at revision: 445
Proposed branch: lp:~bluesabre/xubuntu-default-settings/lightdm-gtk-greeter-updates
Merge into: lp:~xubuntu-dev/xubuntu-default-settings/trunk
Diff against target: 41 lines (+15/-2)
2 files modified
debian/changelog (+7/-0)
etc/xdg/xdg-xubuntu/lightdm/lightdm-gtk-greeter.conf (+8/-2)
To merge this branch: bzr merge lp:~bluesabre/xubuntu-default-settings/lightdm-gtk-greeter-updates
Reviewer Review Type Date Requested Status
Micah Gersten Approve
Sean Davis Needs Resubmitting
Pasi Lallinaho (community) community Approve
Review via email: mp+177959@code.launchpad.net

Commit message

Add clock and on-screen keyboard to lightdm-gtk-greeter.conf

Description of the change

Added updates to the lightdm-gtk-greeter.conf file.
 - Updated configuration comments
 - Added clock with default xubuntu configuration
 - Added on-screen keyboard option with onboard (accessibility)

To post a comment you must log in.
Revision history for this message
Pasi Lallinaho (knome) :
review: Approve (community)
Revision history for this message
Micah Gersten (micahg) wrote :

Could each of these changes be a separate commit to facilitate easier backing out if needed?

review: Needs Fixing
446. By Sean Davis

Remove keyboard commit

447. By Sean Davis

Add accessibility keyboard

Revision history for this message
Sean Davis (bluesabre) wrote :

Hi Micah, could you please review again?

Revision 446 would be the clock-only commit, while 447 adds the keyboard. Is this acceptable?

review: Needs Resubmitting
Revision history for this message
Micah Gersten (micahg) wrote :

This is fine, I didn't realize it was one line.

review: Approve
448. By Sean Davis

Update changelog with lightdm-gtk-greeter changes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-07-18 05:03:26 +0000
+++ debian/changelog 2013-08-28 03:18:05 +0000
@@ -1,3 +1,10 @@
1xubuntu-default-settings (13.10.4) saucy; urgency=low
2
3 * Added clock configuration to lightdm-gtk-greeter.conf
4 * Added on-screen keyboard for accessibility to lightdm-gtk-greeter.conf
5
6 -- Sean Davis <smd.seandavis@gmail.com> Tue, 27 Aug 2013 23:15:23 -0400
7
1xubuntu-default-settings (13.10.3) saucy; urgency=low8xubuntu-default-settings (13.10.3) saucy; urgency=low
29
3 * Added jockey/Additional Drivers launcher to settings.10 * Added jockey/Additional Drivers launcher to settings.
411
=== modified file 'etc/xdg/xdg-xubuntu/lightdm/lightdm-gtk-greeter.conf'
--- etc/xdg/xdg-xubuntu/lightdm/lightdm-gtk-greeter.conf 2013-02-10 19:25:16 +0000
+++ etc/xdg/xdg-xubuntu/lightdm/lightdm-gtk-greeter.conf 2013-08-28 03:18:05 +0000
@@ -5,10 +5,13 @@
5# font-name = Font to use5# font-name = Font to use
6# xft-antialias = Whether to antialias Xft fonts (true or false)6# xft-antialias = Whether to antialias Xft fonts (true or false)
7# xft-dpi = Resolution for Xft in dots per inch (e.g. 96)7# xft-dpi = Resolution for Xft in dots per inch (e.g. 96)
8# xft-hintstyle = What degree of hinting to use (hintnone, hintslight, hintmedium, or hintfull)8# xft-hintstyle = What degree of hinting to use (none, slight, medium, or full)
9# xft-rgba = Type of subpixel antialiasing (none, rgb, bgr, vrgb or vbgr)9# xft-rgba = Type of subpixel antialiasing (none, rgb, bgr, vrgb or vbgr)
10# show-language-selector (true or false)10# show-language-selector (true or false)
11# show-indicators = semi-colon ";" separated list of allowed indicator modules (e.g. indicator-sound.so)11# show-indicators = semi-colon ";" separated list of allowed indicator modules (e.g. libsoundmenu.so)
12# show-clock (true or false)
13# clock-format = strftime-format string, e.g. %H:%M
14# keyboard = command to launch on-screen keyboard
12#15#
13[greeter]16[greeter]
14background=/lib/plymouth/themes/xubuntu-logo/xubuntu-greybird.png17background=/lib/plymouth/themes/xubuntu-logo/xubuntu-greybird.png
@@ -21,3 +24,6 @@
21xft-rgba=rgb24xft-rgba=rgb
22show-language-selector=true25show-language-selector=true
23show-indicators=26show-indicators=
27show-clock=true
28clock-format=%a, %d %b %Y %H:%M
29keyboard=onboard

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: