Merge ~bluca/ubuntu/+source/systemd:jammy_repart into ubuntu/+source/systemd:ubuntu/jammy-devel

Proposed by Luca Boccassi
Status: Needs review
Proposed branch: ~bluca/ubuntu/+source/systemd:jammy_repart
Merge into: ubuntu/+source/systemd:ubuntu/jammy-devel
Diff against target: 92 lines (+30/-2)
4 files modified
debian/changelog (+7/-0)
debian/control (+15/-0)
debian/rules (+2/-2)
debian/systemd-repart.install (+6/-0)
Reviewer Review Type Date Requested Status
Lukas Märdian (community) Approve
Review via email: mp+427557@code.launchpad.net

Commit message

Enable systemd-repart and ship it in a new systemd-repart package.

To post a comment you must log in.
Revision history for this message
Lukas Märdian (slyon) wrote :

We got some response from the SRU team (@racb):

https://lists.ubuntu.com/archives/ubuntu-devel/2022-August/042250.html

Basically he suggests doing this change in a PPA/jammy-backports, or as a entirely new package:

* "what if you were to put systemd-repart as a new package into a PPA, or into jammy-backports?"
* "In general, adding new entirely new packages is considered OK from a regression risk perspective."

Would this work for you @bluca?

Revision history for this message
Luca Boccassi (bluca) wrote :

I've replied on list - I can work on updating this PR to add the new package

Revision history for this message
Luca Boccassi (bluca) wrote :

Updated to add a new systemd-repart package.

Revision history for this message
Lukas Märdian (slyon) wrote :

Thank you Luca, for splitting out the new files into its own systemd-repart binary.

I've staged the changes to provide an upgrade path in Kinetic++:
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?h=ubuntu-kinetic&id=2281670aa8007179170d5cc485bb94e3bbc3b63c

Furthermore, I've re-wrote d/changelog, using "gbp dch", as we usually do in Ubuntu.
And modified d/t/control to add the new binary as a test dependency to the "upstream-2" test case, this avoids skipping TEST-58-REPART.

I've rolled the change into the currently pending Jammy SRU at:
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd

For reference, the new "libssl-dev" build dependency is required to allow for a hmac calculation in sd-repart. Alternatively, this commit could be backported to avoid the dependency: https://github.com/systemd/systemd/commit/ade99252e2cdd9eeff78566789008996d27e4dc0

review: Approve

Unmerged commits

862c15a... by Luca Boccassi

Enable systemd-repart and ship it in a new systemd-repart package

Add fdisk as test dependency, needed by test-repart which calls sfdisk.
Add libfdisk-dev/libssl-dev as dependencies, needed for systemd-repart.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 95b5b03..7e3d8d8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
1systemd (249.11-0ubuntu3.5) jammy; urgency=medium
2
3 * Enable systemd-repart and ship it in the main systemd package.
4 (LP: #1897932)
5
6 -- Luca Boccassi <bluca@debian.org> Thu, 28 Jul 2022 15:35:24 +0100
7
1systemd (249.11-0ubuntu3.4) jammy; urgency=medium8systemd (249.11-0ubuntu3.4) jammy; urgency=medium
29
3 [ Mustafa Kemal Gilor ]10 [ Mustafa Kemal Gilor ]
diff --git a/debian/control b/debian/control
index 103384a..b568352 100644
--- a/debian/control
+++ b/debian/control
@@ -45,12 +45,14 @@ Build-Depends: debhelper-compat (= 13),
45 libkmod-dev (>= 15),45 libkmod-dev (>= 15),
46 libblkid-dev (>= 2.24),46 libblkid-dev (>= 2.24),
47 libmount-dev (>= 2.30),47 libmount-dev (>= 2.30),
48 libfdisk-dev (>= 2.33),
48 libseccomp-dev (>= 2.3.1) [amd64 arm64 armel armhf i386 mips mipsel mips64 mips64el x32 powerpc ppc64 ppc64el riscv64 s390x],49 libseccomp-dev (>= 2.3.1) [amd64 arm64 armel armhf i386 mips mipsel mips64 mips64el x32 powerpc ppc64 ppc64el riscv64 s390x],
49 libdw-dev (>= 0.158) <!stage1>,50 libdw-dev (>= 0.158) <!stage1>,
50 libpolkit-gobject-1-dev <!stage1>,51 libpolkit-gobject-1-dev <!stage1>,
51 libzstd-dev (>= 1.4.0),52 libzstd-dev (>= 1.4.0),
52 libtss2-dev [!i386] <!stage1>,53 libtss2-dev [!i386] <!stage1>,
53 libfido2-dev <!stage1>,54 libfido2-dev <!stage1>,
55 libssl-dev <!stage1>,
54 linux-base <!nocheck>,56 linux-base <!nocheck>,
55 acl <!nocheck>,57 acl <!nocheck>,
56 python3:native,58 python3:native,
@@ -63,6 +65,7 @@ Build-Depends: debhelper-compat (= 13),
63 iproute2 <!nocheck>,65 iproute2 <!nocheck>,
64 zstd <!nocheck>,66 zstd <!nocheck>,
65 gawk <!nocheck>,67 gawk <!nocheck>,
68 fdisk <!nocheck>,
6669
67Package: systemd70Package: systemd
68Architecture: linux-any71Architecture: linux-any
@@ -448,3 +451,15 @@ Description: Userspace out-of-memory (OOM) killer
448 systemd-oomd is a system service that uses cgroups-v2 and451 systemd-oomd is a system service that uses cgroups-v2 and
449 pressure stall information (PSI) to monitor and take action on452 pressure stall information (PSI) to monitor and take action on
450 processes before an OOM occurs in kernel space.453 processes before an OOM occurs in kernel space.
454
455Package: systemd-repart
456Section: admin
457Architecture: linux-any
458Priority: optional
459Depends: ${shlibs:Depends},
460 ${misc:Depends},
461 systemd (= ${binary:Version}),
462Description: Provides the systemd-repart utility
463 systemd-repart is a configuration-driven system partitioning tool. It follows
464 the Discoverable Partitions Specification and provides support for encryption
465 and dm-verity among other things.
diff --git a/debian/rules b/debian/rules
index 201ba05..41945f1 100755
--- a/debian/rules
+++ b/debian/rules
@@ -77,15 +77,15 @@ CONFFLAGS = \
77 -Dfirstboot=false \77 -Dfirstboot=false \
78 -Dxkbcommon=false \78 -Dxkbcommon=false \
79 -Dwheel-group=false \79 -Dwheel-group=false \
80 -Drepart=false \
81 -Duserdb=false \80 -Duserdb=false \
82 -Dhomed=false \81 -Dhomed=false \
83 -Dlibfido2=true \82 -Dlibfido2=true \
84 -Dfdisk=false \
85 -Dpwquality=false \83 -Dpwquality=false \
86 -Dp11kit=false \84 -Dp11kit=false \
87 -Dtpm2=$(if $(filter i386,$(DEB_HOST_ARCH)),false,true) \85 -Dtpm2=$(if $(filter i386,$(DEB_HOST_ARCH)),false,true) \
88 -Doomd=true \86 -Doomd=true \
87 -Drepart=true \
88 -Dfdisk=true \
89 -Dsysext=true \89 -Dsysext=true \
90 -Dnscd=true \90 -Dnscd=true \
91 -Dntp-servers="$(DEFAULT_NTP_SERVERS)" \91 -Dntp-servers="$(DEFAULT_NTP_SERVERS)" \
diff --git a/debian/systemd-repart.install b/debian/systemd-repart.install
92new file mode 10064492new file mode 100644
index 0000000..4cf6bae
--- /dev/null
+++ b/debian/systemd-repart.install
@@ -0,0 +1,6 @@
1bin/systemd-repart
2lib/systemd/system/initrd-root-fs.target.wants/systemd-repart.service
3lib/systemd/system/sysinit.target.wants/systemd-repart.service
4lib/systemd/system/systemd-repart.service
5usr/share/man/man5/repart*
6usr/share/man/man8/systemd-repart*

Subscribers

People subscribed via source and target branches