Merge ~bluca/ubuntu/+source/systemd:jammy_repart into ubuntu/+source/systemd:ubuntu/jammy-devel

Proposed by Luca Boccassi
Status: Needs review
Proposed branch: ~bluca/ubuntu/+source/systemd:jammy_repart
Merge into: ubuntu/+source/systemd:ubuntu/jammy-devel
Diff against target: 92 lines (+30/-2)
4 files modified
debian/changelog (+7/-0)
debian/control (+15/-0)
debian/rules (+2/-2)
debian/systemd-repart.install (+6/-0)
Reviewer Review Type Date Requested Status
Lukas Märdian (community) Approve
Review via email: mp+427557@code.launchpad.net

Commit message

Enable systemd-repart and ship it in a new systemd-repart package.

To post a comment you must log in.
Revision history for this message
Lukas Märdian (slyon) wrote :

We got some response from the SRU team (@racb):

https://lists.ubuntu.com/archives/ubuntu-devel/2022-August/042250.html

Basically he suggests doing this change in a PPA/jammy-backports, or as a entirely new package:

* "what if you were to put systemd-repart as a new package into a PPA, or into jammy-backports?"
* "In general, adding new entirely new packages is considered OK from a regression risk perspective."

Would this work for you @bluca?

Revision history for this message
Luca Boccassi (bluca) wrote :

I've replied on list - I can work on updating this PR to add the new package

Revision history for this message
Luca Boccassi (bluca) wrote :

Updated to add a new systemd-repart package.

Revision history for this message
Lukas Märdian (slyon) wrote :

Thank you Luca, for splitting out the new files into its own systemd-repart binary.

I've staged the changes to provide an upgrade path in Kinetic++:
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?h=ubuntu-kinetic&id=2281670aa8007179170d5cc485bb94e3bbc3b63c

Furthermore, I've re-wrote d/changelog, using "gbp dch", as we usually do in Ubuntu.
And modified d/t/control to add the new binary as a test dependency to the "upstream-2" test case, this avoids skipping TEST-58-REPART.

I've rolled the change into the currently pending Jammy SRU at:
https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd

For reference, the new "libssl-dev" build dependency is required to allow for a hmac calculation in sd-repart. Alternatively, this commit could be backported to avoid the dependency: https://github.com/systemd/systemd/commit/ade99252e2cdd9eeff78566789008996d27e4dc0

review: Approve

Unmerged commits

862c15a... by Luca Boccassi

Enable systemd-repart and ship it in a new systemd-repart package

Add fdisk as test dependency, needed by test-repart which calls sfdisk.
Add libfdisk-dev/libssl-dev as dependencies, needed for systemd-repart.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 95b5b03..7e3d8d8 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+systemd (249.11-0ubuntu3.5) jammy; urgency=medium
7+
8+ * Enable systemd-repart and ship it in the main systemd package.
9+ (LP: #1897932)
10+
11+ -- Luca Boccassi <bluca@debian.org> Thu, 28 Jul 2022 15:35:24 +0100
12+
13 systemd (249.11-0ubuntu3.4) jammy; urgency=medium
14
15 [ Mustafa Kemal Gilor ]
16diff --git a/debian/control b/debian/control
17index 103384a..b568352 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -45,12 +45,14 @@ Build-Depends: debhelper-compat (= 13),
21 libkmod-dev (>= 15),
22 libblkid-dev (>= 2.24),
23 libmount-dev (>= 2.30),
24+ libfdisk-dev (>= 2.33),
25 libseccomp-dev (>= 2.3.1) [amd64 arm64 armel armhf i386 mips mipsel mips64 mips64el x32 powerpc ppc64 ppc64el riscv64 s390x],
26 libdw-dev (>= 0.158) <!stage1>,
27 libpolkit-gobject-1-dev <!stage1>,
28 libzstd-dev (>= 1.4.0),
29 libtss2-dev [!i386] <!stage1>,
30 libfido2-dev <!stage1>,
31+ libssl-dev <!stage1>,
32 linux-base <!nocheck>,
33 acl <!nocheck>,
34 python3:native,
35@@ -63,6 +65,7 @@ Build-Depends: debhelper-compat (= 13),
36 iproute2 <!nocheck>,
37 zstd <!nocheck>,
38 gawk <!nocheck>,
39+ fdisk <!nocheck>,
40
41 Package: systemd
42 Architecture: linux-any
43@@ -448,3 +451,15 @@ Description: Userspace out-of-memory (OOM) killer
44 systemd-oomd is a system service that uses cgroups-v2 and
45 pressure stall information (PSI) to monitor and take action on
46 processes before an OOM occurs in kernel space.
47+
48+Package: systemd-repart
49+Section: admin
50+Architecture: linux-any
51+Priority: optional
52+Depends: ${shlibs:Depends},
53+ ${misc:Depends},
54+ systemd (= ${binary:Version}),
55+Description: Provides the systemd-repart utility
56+ systemd-repart is a configuration-driven system partitioning tool. It follows
57+ the Discoverable Partitions Specification and provides support for encryption
58+ and dm-verity among other things.
59diff --git a/debian/rules b/debian/rules
60index 201ba05..41945f1 100755
61--- a/debian/rules
62+++ b/debian/rules
63@@ -77,15 +77,15 @@ CONFFLAGS = \
64 -Dfirstboot=false \
65 -Dxkbcommon=false \
66 -Dwheel-group=false \
67- -Drepart=false \
68 -Duserdb=false \
69 -Dhomed=false \
70 -Dlibfido2=true \
71- -Dfdisk=false \
72 -Dpwquality=false \
73 -Dp11kit=false \
74 -Dtpm2=$(if $(filter i386,$(DEB_HOST_ARCH)),false,true) \
75 -Doomd=true \
76+ -Drepart=true \
77+ -Dfdisk=true \
78 -Dsysext=true \
79 -Dnscd=true \
80 -Dntp-servers="$(DEFAULT_NTP_SERVERS)" \
81diff --git a/debian/systemd-repart.install b/debian/systemd-repart.install
82new file mode 100644
83index 0000000..4cf6bae
84--- /dev/null
85+++ b/debian/systemd-repart.install
86@@ -0,0 +1,6 @@
87+bin/systemd-repart
88+lib/systemd/system/initrd-root-fs.target.wants/systemd-repart.service
89+lib/systemd/system/sysinit.target.wants/systemd-repart.service
90+lib/systemd/system/systemd-repart.service
91+usr/share/man/man5/repart*
92+usr/share/man/man8/systemd-repart*

Subscribers

People subscribed via source and target branches