Code review comment for lp:~bloodearnest/django-preflight/gargoyle2

Revision history for this message
Simon Davy (bloodearnest) wrote :

> - swap l. 72 and 73 around
> - l 109, 120, 143, 155: fix whitespace before :
> - l.280: why not add in l.270?

Done the above

> - l.398: what's the need of renaming the example_project folder?

This is unfortunately necessary because the nexus package (a dep of gargoyle) is higher in sys.pth when run with "python setup.py test", and it erroneously includes its example_project directory, meaning that the test_suite in setup.py ("example_project.run.tests") was finding the wrong example_project module and failing.

Pull request to exclude example_project upstream: https://github.com/disqus/nexus/pull/5

> - l.428: since you renamed the db, why add the old name to bzrignore? (l. 9)

Done - a left over from earlier

« Back to merge proposal